Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color codes are maybe wrong #77

Open
AdityaTaggar05 opened this issue Feb 24, 2021 · 1 comment
Open

Color codes are maybe wrong #77

AdityaTaggar05 opened this issue Feb 24, 2021 · 1 comment

Comments

@AdityaTaggar05
Copy link
Contributor

I was just testing and running things with termgraph when I noticed that the colors of the graphs seemed a little off. I thought it might the color scheme of Windows Terminal. But on further checking, I found out that the color codes in colorama.Fore and the ones in termgraph are different. Below is the code I ran for checking it.

image

I hope you update the colors accordingly if needed.

@cSquaerd
Copy link

From peaking at the AVAILABLE_COLORS enum in termgraph.py, I think via colorama, its not using the true colors, but rather their ANSI formatting codes. In a 16 or 256 color terminal emulator, these colors can change slightly or greatly depending on your terminal's palette. Is your palette from your screenshot of Solarized, or a similar variant?

A possible fix, try your code and some termgraph tests with either the Tango, XTerm, or Linux Console palettes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants