Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(nsis) needs large string support #221

Open
cbielow opened this issue Nov 8, 2023 · 0 comments
Open

(nsis) needs large string support #221

cbielow opened this issue Nov 8, 2023 · 0 comments

Comments

@cbielow
Copy link

cbielow commented Nov 8, 2023

Expected Behavior

When using NSIS from Chocolatey to create an installer for Windows, this installer currently cannot handle strings larger than ~1024 characters. This makes it almost impossible for the installer to augment the users $PATH (i.e. add any directories for the installed software there).
I would expect Chocolatey to use the 'special build version' which can handle up to 8k strings.

Current Behavior

See above.
The reason is this: https://github.com/kichik/nsis/blob/master/SCons/config.py#L11 default, when NSIS is build.

This has widespread consequences, since GitHub actions is using the Chocolatey NSIS in its runners, i.e. all NSIS-based installers created with GHActions are affected.
see https://github.com/actions/runner-images/blob/main/images/win/scripts/Installers/Install-NSIS.ps1

Possible Solution

Use https://sourceforge.net/projects/nsis/files/NSIS%203/3.09/nsis-3.09-strlen_8192.zip/download instead of the current
https://sourceforge.net/projects/nsis/files/NSIS%203/3.09/nsis-3.09-setup.exe/download
, if that is possible.

Steps to Reproduce (for bugs)

Context

Your Environment

  • Package Version used:
  • Operating System and version:
  • Chocolatey version:
  • Install/uninstall gist:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant