From 5dc0d3442031ff7d3a556b426afeda1becc8284d Mon Sep 17 00:00:00 2001 From: Cory Date: Tue, 16 Aug 2016 11:20:57 -0400 Subject: [PATCH] Remove unused `liveJs` option There do not appear to be any LiveReload client implementations that do live JS reloading. See also https://github.com/mklabs/tiny-lr/issues/107, which discusses `livereactload` (which does offer live JS reloading in very specific circumstances but does not appear to be a full livereload implementation) and [`issue 18 at livereload-js`](https://github.com/livereload/livereload-js/issues/18), which points out that livereload-js does not do live js reloading. livereload-js currently observes the [`liveCSS` and `liveImg` options](https://github.com/livereload/livereload-js/blob/20e9c3a5a4e33d46f616741394130e93472adc2c/src/livereload.coffee#L93-L94), but not `liveJs`. --- lib/client.js | 1 - readme.md | 1 - 2 files changed, 2 deletions(-) diff --git a/lib/client.js b/lib/client.js index c46263b..504864a 100644 --- a/lib/client.js +++ b/lib/client.js @@ -58,7 +58,6 @@ class Client extends events.EventEmitter { command: 'reload', path: file, liveCSS: this.options.liveCSS !== false, - liveJs: this.options.liveJs !== false, liveImg: this.options.liveImg !== false }); }, this); diff --git a/readme.md b/readme.md index d188c7b..ff5d24c 100644 --- a/readme.md +++ b/readme.md @@ -153,7 +153,6 @@ See [gulp-livereload](https://github.com/vohof/gulp-livereload) repo. - `cert` - Option to pass in to create an https server - `pfx` - Can also be used to create an https server instead of `key` & `cert` - `liveCSS` - LiveReload option to enable live CSS reloading (defaults to true) -- `liveJs` - LiveReload option to enable live JS reloading (defaults to true) - `liveImg` - LiveReload option to enable live images reloading (defaults to true) - `dashboard` - A boolean to prevent tiny-lr from configuring a default "home" route. Only used with the CLI (default: false)