Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: switch to livereactload #107

Open
mklabs opened this issue Aug 12, 2016 · 6 comments
Open

Question: switch to livereactload #107

mklabs opened this issue Aug 12, 2016 · 6 comments
Labels

Comments

@mklabs
Copy link
Owner

mklabs commented Aug 12, 2016

relates to #103 comment

Switching to livereactload may provide the net benefit of hot reloading for JS code. CSS and images needs to be figured out, I'm not sure livereactload handles it at all.

Maybe in combination with livereloadjs, though it seems difficult to handle both of them and make them work together.

@mklabs mklabs mentioned this issue Aug 12, 2016
13 tasks
@elwayman02
Copy link
Collaborator

LiveReactload requires watchify, babelify and react >= 0.13.x in order to work.

This seems to be a non-starter. If livereactload requires React, we would be forcing every project using tiny-lr (which includes many Angular/Ember projects, among others) to add React as a dependency.

@elwayman02
Copy link
Collaborator

Wouldn't this also further assume that everyone using tiny-lr is using browserify?

@elwayman02
Copy link
Collaborator

You can use LiveReactload with all build systems having Browserify and Watchify support.

@mklabs
Copy link
Owner Author

mklabs commented Aug 12, 2016

You're right. A lot of assumptions and implied dependencies ^^

Though, I'd really like to experiment with this idea even though it seems a huge undertaking.

I'm working on the CLI part and was willing to try switching over it and see how it goes. Thinking about it, I think this is too much work for tiny-lr.

@elwayman02
Copy link
Collaborator

I am intrigued by the hot reload for JS, but we'd need a much lower-level dependency for that to make sense, I think.

@mklabs
Copy link
Owner Author

mklabs commented Aug 12, 2016

Maybe there is some way to have the CLI part (which eventually would be separate from tiny-lr) use or reuse part of livereactload, not really sure.

but we'd need a much lower-level dependency for that to make sense, I think.

I definitely agree.

bantic added a commit to bantic/tiny-lr that referenced this issue Aug 16, 2016
There do not appear to be any LiveReload client implementations that do
live JS reloading.

See also mklabs#107, which discusses
`livereactload` (which does offer live JS reloading in very specific
circumstances but does not appear to be a full livereload implementation) and [`issue 18 at
livereload-js`](livereload/livereload-js#18),
which points out that livereload-js does not do live js reloading.

livereload-js currently observes the [`liveCSS` and `liveImg`
options](https://github.com/livereload/livereload-js/blob/20e9c3a5a4e33d46f616741394130e93472adc2c/src/livereload.coffee#L93-L94),
but not `liveJs`.
mklabs pushed a commit that referenced this issue Aug 17, 2016
There do not appear to be any LiveReload client implementations that do
live JS reloading.

See also #107, which discusses
`livereactload` (which does offer live JS reloading in very specific
circumstances but does not appear to be a full livereload implementation) and [`issue 18 at
livereload-js`](livereload/livereload-js#18),
which points out that livereload-js does not do live js reloading.

livereload-js currently observes the [`liveCSS` and `liveImg`
options](https://github.com/livereload/livereload-js/blob/20e9c3a5a4e33d46f616741394130e93472adc2c/src/livereload.coffee#L93-L94),
but not `liveJs`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants