-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: switch to livereactload #107
Comments
This seems to be a non-starter. If livereactload requires React, we would be forcing every project using tiny-lr (which includes many Angular/Ember projects, among others) to add React as a dependency. |
Wouldn't this also further assume that everyone using tiny-lr is using browserify? |
|
You're right. A lot of assumptions and implied dependencies ^^ Though, I'd really like to experiment with this idea even though it seems a huge undertaking. I'm working on the CLI part and was willing to try switching over it and see how it goes. Thinking about it, I think this is too much work for tiny-lr. |
I am intrigued by the hot reload for JS, but we'd need a much lower-level dependency for that to make sense, I think. |
Maybe there is some way to have the CLI part (which eventually would be separate from tiny-lr) use or reuse part of livereactload, not really sure.
I definitely agree. |
There do not appear to be any LiveReload client implementations that do live JS reloading. See also mklabs#107, which discusses `livereactload` (which does offer live JS reloading in very specific circumstances but does not appear to be a full livereload implementation) and [`issue 18 at livereload-js`](livereload/livereload-js#18), which points out that livereload-js does not do live js reloading. livereload-js currently observes the [`liveCSS` and `liveImg` options](https://github.com/livereload/livereload-js/blob/20e9c3a5a4e33d46f616741394130e93472adc2c/src/livereload.coffee#L93-L94), but not `liveJs`.
There do not appear to be any LiveReload client implementations that do live JS reloading. See also #107, which discusses `livereactload` (which does offer live JS reloading in very specific circumstances but does not appear to be a full livereload implementation) and [`issue 18 at livereload-js`](livereload/livereload-js#18), which points out that livereload-js does not do live js reloading. livereload-js currently observes the [`liveCSS` and `liveImg` options](https://github.com/livereload/livereload-js/blob/20e9c3a5a4e33d46f616741394130e93472adc2c/src/livereload.coffee#L93-L94), but not `liveJs`.
relates to #103 comment
Switching to livereactload may provide the net benefit of hot reloading for JS code. CSS and images needs to be figured out, I'm not sure livereactload handles it at all.
Maybe in combination with livereloadjs, though it seems difficult to handle both of them and make them work together.
The text was updated successfully, but these errors were encountered: