Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Improve code highlight #113

Closed
lucas-goldner opened this issue Sep 26, 2024 · 2 comments
Closed

refactor: Improve code highlight #113

lucas-goldner opened this issue Sep 26, 2024 · 2 comments

Comments

@lucas-goldner
Copy link
Contributor

Description

Having worked on two presentations with flutter_deck, I am enjoying it, but one thing I think could be improved: Showing code.

Design:

Here are two screenshots comparing how it looks on flutter_deck and how I implemented it in fluttershow:

flutter_deck
image

fluttershow
image

You can check the implementation here:
https://github.com/lucas-goldner/fluttershow_base/blob/main/lib/components/widgets/wrapper/code_display.dart

I also have like a billion themes hard coded:
https://github.com/lucas-goldner/fluttershow_base/blob/main/lib/components/model/enum/code_display_themes.dart

Maybe we could merge them somehow for a more appealing view

Auto format:

This would only work for Dart, but manually formatting can be annoying.
I used this library here:
https://github.com/lucas-goldner/fluttershow_base/blob/main/lib/components/helper/format_code.dart
Of course, it should be toggleable

Requirements

If you agree with any of those points, we can define requirements

@mkobuolys
Copy link
Owner

Hey! I think this issue can be closed and the discussion moved to #94. Using the same code styling as used in the slick_slides package should also solve this.

@lucas-goldner
Copy link
Contributor Author

Ah didn't see that one, yeah then let's use the slick one 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants