Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in handPose and bodyPose Methods section #163

Open
jackbdu opened this issue Aug 8, 2024 · 5 comments
Open

Typos in handPose and bodyPose Methods section #163

jackbdu opened this issue Aug 8, 2024 · 5 comments

Comments

@jackbdu
Copy link

jackbdu commented Aug 8, 2024

In the Methods section of handPose Reference, handPose is currently referred to as handpose.

@alanvww
Copy link
Member

alanvww commented Aug 8, 2024

In the Methods section of handPose Reference, handPose is currently referred to as handpose.

Thanks Jack! Will include it into the latest docs update :)

@MOQN
Copy link
Member

MOQN commented Aug 8, 2024

@jackbdu Nice catch! Thank you.
@alanvww I just fixed the typo! PR #164

@jackbdu
Copy link
Author

jackbdu commented Aug 9, 2024

@MOQN Thanks for the quick response! Sorry I might have not made it super clear, it seems all occurrences of handPose in the section are currently handpose.

@jackbdu jackbdu changed the title Typo in handPose Reference Methods Section Typos in handPose and bodyPose Methods section Aug 9, 2024
@jackbdu
Copy link
Author

jackbdu commented Aug 9, 2024

In addition, in bodyPose > Methods > Parameters > options, there is a missing comma and a missing letter R near the end of modelType line:
modelType: "MULTIPOSE_LIGHTNING", // "MULTIPOSE_LIGHTNING", "SINGLEPOSE_LIGHTNING", or "SINGLEPOSE_THUNDER"

@alanvww
Copy link
Member

alanvww commented Aug 9, 2024

@jackbdu thanks Jack🥲 fixing them now!!!

@MOQN Please check PR #166

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants