Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformer appears to be outdated, lower BLEU #112

Open
ableiweisss opened this issue Oct 11, 2018 · 4 comments
Open

Transformer appears to be outdated, lower BLEU #112

ableiweisss opened this issue Oct 11, 2018 · 4 comments
Labels
Backlog An issue to be discussed in a future Working Group, but not the immediate next one.

Comments

@ableiweisss
Copy link

The Transfomer code in MLPerf is a bit outdated, and has a BLEU score lower than the official TensorFlow version:

https://github.com/tensorflow/models/tree/master/official/transformer

@tremblerz
Copy link

tremblerz commented Oct 11, 2018

Hi @ableiweisss
Would you like to point out what aspect of Transformer appears to be outdated? Is it the preprocessing module, main model or the code performing evaluation?

Regarding the BLEU score, there was some discussion before also whether it should be kept the same as the score reported in the original paper. My understanding is that, once the BLEU score has crossed value of 22~23, further improvement in the BLEU score is marginal with respect to the number of training epochs and can bring certain inconsistency in training time due to random seed ( see mlcommons/training#125 ).

@ableiweisss
Copy link
Author

Hi @tremblerz
The official TensorFlow repo reports a BLEU score of 27.7 for base and 28.9 for big. MLPerf reports 25, which is significantly lower. Is this due to code differences or rather as a target simply related to minimizing the number of epochs?

@ddutta
Copy link

ddutta commented Oct 11, 2018 via email

@bitfort bitfort added the Next Meeting Item to be discussed in the next Working Group label Oct 16, 2018
@petermattson
Copy link
Contributor

SWG:
We plan to raise for 5.1.

@bitfort bitfort added Rec: Rules Change A recommendation has been issued by the Working Group. and removed Next Meeting Item to be discussed in the next Working Group labels Oct 29, 2018
@petermattson petermattson added Postponed 5.1 and removed Rec: Rules Change A recommendation has been issued by the Working Group. labels Nov 6, 2018
@petermattson petermattson added Backlog An issue to be discussed in a future Working Group, but not the immediate next one. and removed Postponed 5.1 labels May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backlog An issue to be discussed in a future Working Group, but not the immediate next one.
Projects
None yet
Development

No branches or pull requests

5 participants