Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vocab File for transformer model #200

Open
bitfort opened this issue May 2, 2019 · 3 comments
Open

Vocab File for transformer model #200

bitfort opened this issue May 2, 2019 · 3 comments

Comments

@bitfort
Copy link

bitfort commented May 2, 2019

There are changes being made to transformer reference for how the vocab file is read.

@bitfort bitfort added Next Meeting Item to be discussed in the next Working Group Rec: Rules Change A recommendation has been issued by the Working Group. and removed Next Meeting Item to be discussed in the next Working Group labels May 2, 2019
@bitfort
Copy link
Author

bitfort commented May 2, 2019

SWG Notes:

There is pending work being done to the vocab loading for transformer reference, this work will not be completed before the submission (re: PR 257). The reference is effectively the reference plus PR 257 with the understanding that the intention is to read the vocab from the specified file and that this still under review and specific details may be flexible.

PR https://github.com/mlperf/training/pull/257/files
The vocab file is already in the reference repo.

@petermattson petermattson added Next Meeting Item to be discussed in the next Working Group and removed Rec: Rules Change A recommendation has been issued by the Working Group. labels May 29, 2020
@petermattson
Copy link
Contributor

Moved to active, we still haven't committed PR. Any issues?

@bitfort bitfort added Rec: Code Change and removed Next Meeting Item to be discussed in the next Working Group labels Jun 11, 2020
@bitfort
Copy link
Author

bitfort commented Jun 11, 2020

SWG:

PR Should be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants