Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Dead Code" #207

Open
bitfort opened this issue May 9, 2019 · 2 comments
Open

"Dead Code" #207

bitfort opened this issue May 9, 2019 · 2 comments

Comments

@bitfort
Copy link

bitfort commented May 9, 2019

We found 2 specific examples of "dead code" where references appears to not be useful or relevant to mlperf.

Example (1): transformer running an extra eval on newstest 2013 (and printing eval acc).
Example (2): SSD saving snapshots/checkpoints and additional prints.

@bitfort bitfort added Next Meeting Item to be discussed in the next Working Group Rec: Rules Change A recommendation has been issued by the Working Group. and removed Next Meeting Item to be discussed in the next Working Group labels May 9, 2019
@bitfort
Copy link
Author

bitfort commented May 9, 2019

SWG Notes:

We intend to eliminate "dead code" from the reference and submitters are not expected to implement this kind of dead code which is not relevant to the primary data pipeline/training/mlperf eval work.

Specific examples of what submitters don't need to implement:
Example (1): transformer running an extra eval on newstest 2013 (and printing eval acc).
Example (2): SSD saving snapshots/checkpoints and additional prints.

We note that we have already stated checkpoints are optional for MLPerf v0.6.

@petermattson petermattson added AI There is an action item here. Next Meeting Item to be discussed in the next Working Group Rec: Rules Change A recommendation has been issued by the Working Group. and removed Rec: Rules Change A recommendation has been issued by the Working Group. Next Meeting Item to be discussed in the next Working Group labels May 29, 2020
@petermattson
Copy link
Contributor

Should do this to references rather than try to encode it in rules.

@petermattson petermattson added Rec: Code Change and removed AI There is an action item here. Rec: Rules Change A recommendation has been issued by the Working Group. labels May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants