Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RasterEquidistantMetricSpace errors with scipy 1.0 #186

Open
mmaelicke opened this issue Jun 26, 2024 · 2 comments
Open

RasterEquidistantMetricSpace errors with scipy 1.0 #186

mmaelicke opened this issue Jun 26, 2024 · 2 comments
Labels

Comments

@mmaelicke
Copy link
Owner

This line is not supported anymore with scipy 1.0:

dok._update(zip(zip(c, eq), d))

see also scipy/scipy#8338

With #185 the bug is fixed for now, as the old, slower code is used again. If we want to change the dok matrix directly we need to do that via fancy indexing. @rhugonnet if I remember correctly, you implemented this class, right? Can you comment on this?

I just commented out the non-working solution, so to close this issue we could either remove the commented code, or implement a better solution.

@mmaelicke mmaelicke added the bug label Jun 26, 2024
@rhugonnet
Copy link
Contributor

@mmaelicke Just back from holidays, I'll have a look very soon!

@rhugonnet
Copy link
Contributor

Hi @mmaelicke, I looked at this again this afternoon.
I could not find a solution to keep the old (fast) method post-SciPy 1.13. The classic update() still does not work. It's good that we have the other solution at least.

I will have to dive into this more when I address the other points I mentioned in #178 to revamp that metric space and document it! It'll probably end in opening a SciPy issue to ask about that functionality.

I think we can close this issue, and I will rename #178 towards documenting the RasterMetricSpace!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants