Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making epochs optional #292

Open
MerlinDumeur opened this issue Apr 15, 2021 · 12 comments
Open

Making epochs optional #292

MerlinDumeur opened this issue Apr 15, 2021 · 12 comments

Comments

@MerlinDumeur
Copy link
Contributor

MerlinDumeur commented Apr 15, 2021

Hi,

Right now the way the pipeline is set-up, epoching is necessary.

I would however need to apply the ica on the raw recording instead of the epoched data.
Is it planned for this pipeline to be able to do that? I will need to do it anyway, and I'll be happy to have my version of the code which does that, but it might be interesting to add this feature as a PR here.

Please let me know what you think

@agramfort
Copy link
Member

agramfort commented Apr 15, 2021 via email

@hoechenberger
Copy link
Member

one issue with ICA on raw data is that it makes it harder to remove bad data segments

You mean because if there's a bad segment, we get edge artifacts, whereas with epochs, we would drop the entire epoch?

@agramfort
Copy link
Member

agramfort commented Apr 15, 2021 via email

@MerlinDumeur
Copy link
Contributor Author

Ok so if I understand correctly the options are:

  • Annotate bad segments in the raw data, then compute ICA on the raw data, ignoring bad segments.
  • Compute the ICA on epoched data, and apply it on the raw data.

It seems to me that the second option would be easiest, but maybe not optimal, and I will likely need to annotate bad segments anyway.
Would it be possible to arbitrarily segment the data into small epochs, and apply the rejection method from mne?
Otherwise, would it be feasible to use SSP instead?

@agramfort
Copy link
Member

agramfort commented Apr 15, 2021 via email

@MerlinDumeur
Copy link
Contributor Author

yes that's what I meant.

If there's any way I can help with adding this to the pipeline, I'd be happy to because I will need it.

@agramfort
Copy link
Member

agramfort commented Apr 15, 2021 via email

@MerlinDumeur
Copy link
Contributor Author

MerlinDumeur commented Apr 15, 2021

I'll get on it then

@agramfort
Copy link
Member

agramfort commented Apr 15, 2021 via email

@hoechenberger
Copy link
Member

Amazing!

@moritz-gerster
Copy link

I'll get on it then

I guess it will take some more time? :)

@drammock
Copy link
Member

@moritz-gerster see WIP #296 and discussion there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants