Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul of the StreamViewer #51

Open
5 tasks
mscheltienne opened this issue Feb 12, 2022 · 2 comments · May be fixed by #174
Open
5 tasks

Overhaul of the StreamViewer #51

mscheltienne opened this issue Feb 12, 2022 · 2 comments · May be fixed by #174
Labels
🌟 enhancement Proposed improvement or feature request. viewer Issues related to the Viewer API.
Milestone

Comments

@mscheltienne
Copy link
Member

mscheltienne commented Feb 12, 2022

The StreamViewer API needs an overhaul. It will be rename as Viewer to match the new Stream and Player API. The new Viewer API will interface with one or more Stream and will use methods from Stream to edit the stream properties:

  • Possibility to change the channel names
  • Possibility to change the channel types (will automatically adapt the trace colors, the trace y-range)
  • Possibility to change the channel units (will automatically adapt the trace y-range)
  • Possibility to set a filter per channel
  • Possibility to set the EEG reference

Moreover, the Viewer should be able to connect to multiple streams. Streams with a regular sampling rate should be displayed as channels (/!\ identical channel names between streams must be covered) while streams with an irregular sampling rate should be displayed as vertical lines.

For the filter, some thinking is required to compensate or ignore the causal delay introduced on one or all channels (and between a regular sampling rate stream and the vertical lines from an irregular one).

The backend should be pyqtgraph with OpenGL for better display.

@mscheltienne
Copy link
Member Author

For real-time annotation, the causality of the filter prevents us from getting a clear relationship between a location on the viewing area and a location in the saved dataset. PR #47 can serve as a basis for a second attempt.

@mscheltienne
Copy link
Member Author

Depends on the overhaul of the Receiver API:

@mscheltienne mscheltienne changed the title Overhaul for the StreamViewer Overhaul of the StreamViewer Sep 2, 2023
@mscheltienne mscheltienne modified the milestones: 1.1, 1.2 Nov 20, 2023
@mscheltienne mscheltienne modified the milestones: 1.2, 1.3 Jan 24, 2024
@mscheltienne mscheltienne modified the milestones: 1.3, 1.4 Mar 7, 2024
@mscheltienne mscheltienne modified the milestones: 1.4, 1.5 May 29, 2024
@mscheltienne mscheltienne modified the milestones: 1.5, 1.6 Aug 6, 2024
@mscheltienne mscheltienne modified the milestones: 1.6, 1.7 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 enhancement Proposed improvement or feature request. viewer Issues related to the Viewer API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant