limit days at webcam download #186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the-infinity
force-pushed
the
limit-days-at-webcam-download
branch
from
07e42b8 to
6a8336a
Compare
derhuerst
reviewed
Feb 20, 2025
| @@ -8,5 +8,7 @@ set -x | |||
| find /var/webcam -mtime +$IPL_WEBCAM_KEEP_DAYS -type f -delete | |||
| # Delete all empty directories | |||
| find /var/webcam -type d -empty -delete | |||
| # Download all new files | |||
| lftp -e "mirror -c --parallel=$IPL_WEBCAM_WORKER --verbose / /var/webcam; quit;" -u $IPL_WEBCAM_USER,$IPL_WEBCAM_PASSWORD $IPL_WEBCAM_SERVER | |||
| # Download all new files. Limit to now -(DOWNLOAD_MAX_DAYS - 1) days, otherwise we would delete and re-download data | |||
There was a problem hiding this comment.
Can you elaborate a bit more? Is this because because now - 6 days effectively describes a time span of 7 days because the calculation is only precise to the day?
derhuerst
reviewed
Feb 21, 2025
| @@ -8,5 +8,7 @@ set -x | |||
| find /var/webcam -mtime +$IPL_WEBCAM_KEEP_DAYS -type f -delete | |||
| # Delete all empty directories | |||
| find /var/webcam -type d -empty -delete | |||
| # Download all new files | |||
| lftp -e "mirror -c --parallel=$IPL_WEBCAM_WORKER --verbose / /var/webcam; quit;" -u $IPL_WEBCAM_USER,$IPL_WEBCAM_PASSWORD $IPL_WEBCAM_SERVER | |||
| # Download all new files. Limit to now -(DOWNLOAD_MAX_DAYS - 1) days, otherwise we would delete and re-download data | |||
There was a problem hiding this comment.
Suggested change
| # Download all new files. Limit to now -(DOWNLOAD_MAX_DAYS - 1) days, otherwise we would delete and re-download data | |
| # Download all new files. Limit to now -(IPL_WEBCAM_KEEP_DAYS - 1) days, otherwise we would delete and re-download data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out, that the data source changed the amount of days they offer, which ended up into deleting and redownloading all files older then 7 days all the time, which again blocked necessary ports. This MR prevents this.