fix gtfs import: let pgbouncer close client connections on reconfiguration, other tweaks #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, LGTM. This change will result in pgbouncer closing connections which still might be in idle sessions of clients, i.e. postgREST. Reading postgREST docs, I understand that postgREST will attempt an automatic recovery, so clients usually would not notice, right? |
Yes, this is what I understood too, and while testing it locally, it seemed that this is the case. (I may have made a mistake trying to reproduce the case though.) |
This is a workaround until bitnami/containers#54732 is merged & shipped.
PostgREST uses a separate long-running (separate) DB connection to listen on a pub/sub channel for instructions to reload its schema (cache). By default, pgbouncer *does not* force-close idle connections on reconfigurations. Although we recently configured pgbouncer to do so, we don't need this on-demand schema reloading feature anyways, so we turn it off.
derhuerst
force-pushed
the
fix-gtfs-import
branch
from
0f20937 to
d8558f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
342e0e7 is the actual fix, the other commits are related cleanups.
This PR is a workaround; When bitnami/containers#54732 is merged & shipped, we can remove the custom script and use just
PGBOUNCER_SERVER_FAST_CLOSE: '1'.