Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing test cases #93

Open
4 of 6 tasks
jajik opened this issue Jun 1, 2023 · 4 comments
Open
4 of 6 tasks

Missing test cases #93

jajik opened this issue Jun 1, 2023 · 4 comments
Assignees

Comments

@jajik
Copy link
Collaborator

jajik commented Jun 1, 2023

Currently, tests are missing:

@rhusar
Copy link
Member

rhusar commented Jun 1, 2023

@jajik Is this regarding https://github.com/modcluster/mod_proxy_cluster/tree/main/test ? Do we have instructions how to run these?

@jajik
Copy link
Collaborator Author

jajik commented Jun 1, 2023

Yes. And more or less yes. There is a README within test/native/ that describes it a bit. It might be worth it to mention it in the main README.

@rhusar
Copy link
Member

rhusar commented Jun 1, 2023

Just for the context, when I created (split) the mod_proxy_cluster repository I did not cleanup the test infrastructure to get everything running again, so this has been on the back burner for quite a while now.
Regarding the readme, I am also considering the idea of having this as part of the https://docs.modcluster.io/ - it's flexible, convenient to edit, doesn't pollute the source code SCM repo, etc.
Moreover, the other goal is to get these tests running regularly in CI. Similarly, on the mod_cluster repo, the goal is to run real integration tests with real containers.

@jajik jajik self-assigned this Oct 25, 2024
@jajik
Copy link
Collaborator Author

jajik commented Oct 31, 2024

Several testcases were added in #283

edit: Jut to clarify, MODCLUSTER-204 was superseded by #271 so now the truncation does not happen and corresponding request are treated as erroneous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants