Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit error in Modelica.Mechanics.MultiBody.Examples.Loops.Utilities.GasForce2 #4080

Closed
qlambert-pro opened this issue Mar 3, 2023 · 3 comments · Fixed by #4081
Closed

Unit error in Modelica.Mechanics.MultiBody.Examples.Loops.Utilities.GasForce2 #4080

qlambert-pro opened this issue Mar 3, 2023 · 3 comments · Fixed by #4081
Labels
example Issue only addresses example(s) L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Milestone
MSL4.1.0

Comments

@qlambert-pro
Copy link
Contributor

For R_air:

  constant SI.SpecificHeatCapacity R_air = Modelica.Constants.R / 0.0289651159;

we should introduce the molar mass of air, if I am not mistaken.
@tobolar
Copy link
Contributor

tobolar commented Mar 3, 2023 •
edited
Loading

Something like(?)

  constant SI.MolarMass MM_air = 0.0289651159;
  constant SI.SpecificHeatCapacity R_air = Modelica.Constants.R/MM_air;

Actually, I guess it shall be MM of a gas compound in a combustion engine. (But maybe not so important.)

@qlambert-pro
Copy link
Contributor Author

qlambert-pro commented Mar 3, 2023 •
edited
Loading

That's what I had in mind. If we go by this proposal: modelica/ModelicaSpecification#3266, this is the sort of things tools should start rejecting.

@tobolar
Copy link
Contributor

tobolar commented Mar 3, 2023

The fix shall be straightforward as the definition of R_air is protected.

@tobolar tobolar mentioned this issue Mar 3, 2023
Merged
@beutlich beutlich added L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody example Issue only addresses example(s) labels Jun 1, 2023
@beutlich beutlich added this to the MSL4.1.0 milestone Jun 1, 2023
@qlambert-pro qlambert-pro mentioned this issue Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
example Issue only addresses example(s) L: Mechanics.MultiBody Issue addresses Modelica.Mechanics.MultiBody
Projects
None yet
Milestone
MSL4.1.0
3 participants
@qlambert-pro @tobolar @beutlich