Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Modelica.Fluid.Pipes.BaseClasses.FlowModels.PartialGenericPipeFlow to avoid using the functions handling static head if the pipe is horizontal #4525

Open
casella opened this issue Feb 9, 2025 · 0 comments
Assignees
Labels
L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Milestone

Comments

@casella
Copy link
Contributor

casella commented Feb 9, 2025

In #3758 and #4312, some issues were resolved because of bogus behaviour of regfun3() when called by wall friction models in the special case of horizontal pipe. This gave rise to some singularities that led to bad numerical behaviour.

Hopefully this was fixed by PRs #4157 and #4522. However, as suggested by @sielemann in in #3758, we should probably fix Modelica.Fluid.Pipes.BaseClasses.FlowModels.PartialGenericPipeFlow so that it completely skips the part that accounts for static head if max(abs(dheights)) < eps, i.e., the pipe is horizontal.

@casella casella added the L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation) label Feb 9, 2025
@casella casella added this to the MSL4.2.0 milestone Feb 9, 2025
@casella casella self-assigned this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: Fluid Issue addresses Modelica.Fluid (excl. Dissipation)
Projects
None yet
Development

No branches or pull requests

1 participant