Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character images shouldn't be full section height #50

Open
pandaxtc opened this issue Mar 1, 2019 · 1 comment
Open

Character images shouldn't be full section height #50

pandaxtc opened this issue Mar 1, 2019 · 1 comment

Comments

@pandaxtc
Copy link
Member

pandaxtc commented Mar 1, 2019

Maybe just a subjective thing, but they shouldn't go all the way up to the tip top of the section. Maybe add some top padding?

@Xetera
Copy link
Member

Xetera commented Mar 2, 2019

This is somewhat difficult to get right due to the layout of the sections. The images move down with the length of the info section, but padding moves down both of the elements. You can try to see if there's a way to make it work nicer but as far as I'm aware, this isn't a very easy thing to do rn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants