[FEAT] Specify logger within SettingsCreator

[will-holley]

Is your proposal related to a problem?

More ergonomics than problem.

Describe the solution you'd like

SettingsCreator to support a logger argument with the signature:

logger: logging.Logger = logging.getLogger(__name__)

Calls to module-scoped logger instances would be replaced.

Describe alternatives you've considered

Monkey patching each module that I'm calling the functions of, for example:

import logging
from splink.internals import linker as splink_linker_module

class MyLogger(logging.Logger):
  pass

splink_linker_module.logger = MyLogger()

Additional context

Happy to take this up.

[RobinL]

Thanks for raising this. Not sure I totally follow what you're after. Can you achieve the same thing by setting set_up_basic_logging to False and then configuring logging how you want?

splink/splink/internals/linker.py

Line 79 in 885f1fb

set_up_basic_logging: bool = True,

splink/splink/internals/linker.py

Line 132 in 885f1fb

if set_up_basic_logging: