Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSSION] Should torch generators not generate context methods at all? #392

Open
cpjolicoeur opened this issue May 18, 2023 · 0 comments
Milestone

Comments

@cpjolicoeur
Copy link
Member

When #182 is finally merged, the new Torch.Pagination module will be included as a macro to create the paginate_* and filter_config/1 methods that previously were injected directly into the context module. Should this be taken one step further, and all methods (change_, create_, delete_, get_!, list_, update_) also just be available via the use macro?

These methods could/would be defined via defoverridable so that users could customize them if desired.

This could have the nice side-effect of not cluttering up context modules. On the other hand, being explicit and having those methods directly available to the user via the generator task is nice, and sort of the expected output of running the generator. This being an admin tool, where these methods likely aren't updated often by most users, I'm not sure which is more desirable.

@cpjolicoeur cpjolicoeur added this to the v5.0.0 milestone May 18, 2023
@cpjolicoeur cpjolicoeur changed the title Should torch generators not generate context methods at all [DISCUSSION] Should torch generators not generate context methods at all? Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant