-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look into migrating from Scrivener to Flop #479
Comments
A temporary option could be to use a fork of Scrivener in the mean time, for example to apply this PR which would unblock people using Torch from updating to Ecto 3.12.0. |
Yeah, we should this in the short term for sure to unblock people currently blocked. |
Fix issue with using Torch for users who have Ecto >= 3.12.0 * #479 * mojotech/scrivener_ecto#105
Fix issue with using Torch for users who have Ecto >= 3.12.0 * #479 * mojotech/scrivener_ecto#105
Fix issue with using Torch for users who have Ecto >= 3.12.0 * #479 * mojotech/scrivener_ecto#105
@adamu Torch v5.3.2 was published that includes a hex package fork of scrivener ecto with the PR you linked to applied. Any chance you could vet that this fixes any blockers for Ecto 3.12.0+? |
@cpjolicoeur Can confirm I was able to deploy this Torch version alongside Ecto 3.12.3. Pagination looks ok, too. It appears the hexdocs are broken again, though. |
@adamu Thanks for confirming that. I'll look into the broken docs. I'm not sure why it keeps breaking on the hex.pm published docs when things compile fine for me locally. I'll look into it and fix though. Appreciate it. BTW, |
@adamu Docs should be updated I think. |
Scrivener/Scrivener_Ecto are in low maintenance mode and no longer being updated/supported.
https://github.com/woylie/flop
https://github.com/woylie/flop_phoenix
UPDATE
We have taken over maintenance of Scrivener and Scrivener.Ecto so this should be exploratory. If it makes sense to transition to Flop and keep Scrivener in low maintenance mode, we should look into it. Otherwise, we can/should do some updates on Scrivener and take it out of low maint mode.
The text was updated successfully, but these errors were encountered: