Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong param order in implode function #44

Open
bYemma opened this issue Feb 17, 2025 · 1 comment
Open

Wrong param order in implode function #44

bYemma opened this issue Feb 17, 2025 · 1 comment

Comments

@bYemma
Copy link

bYemma commented Feb 17, 2025

The order of the params of the implode function is wrong:

'addinfo' => !empty($aStreet) ? implode($aStreet, ' ') : '',

The result is the following error message:
implode(): Argument #2 ($array) must be of type ?array, string given

A correct param order would be look like this:

'addinfo' => !empty($aStreet) ? implode(' ', $aStreet) : '',

Source: https://www.php.net/implode

@bYemma
Copy link
Author

bYemma commented Feb 17, 2025

This is the only wrong param order of implode in the module: https://github.com/search?q=repo%3Amollie%2Foxid7%20implode(&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant