Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should injectDB async? #5

Open
Jon-000 opened this issue Nov 12, 2019 · 1 comment
Open

should injectDB async? #5

Jon-000 opened this issue Nov 12, 2019 · 1 comment

Comments

@Jon-000
Copy link

Jon-000 commented Nov 12, 2019

this is a very great material to learn, thanks!
but i am confused about something.
at src/dao/movieDAO.js file, there is a injectDB method, should this method async?
i mean, what passed to this method is a MongoClient which i think already established an connection, so it does not need async any more. and it seems conn.db() not return a promise.
am i right? or which part of my thought is wrong? thx.
@lisa-gogo
Copy link

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jon-000 @lisa-gogo