-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensor data precision lost #1194
Comments
I tweeted the UI it will show one digit in the next release. But in HomeKit we are limited to int values. Volts will come in the future. |
Why are you limited to int values in Homekit? |
We don't do that, the specification does it. HomeKit has no official support for W or Wh (V too), but HomeKit supports custom values, that's what Eve does. There is no official specification about what Eve does. So we depend on reverse engineered specifications. That specification says that it is an integer value. Maybe Eve has a newer specification which now supports floats. I have tested our implementation rewritten as float and the Eve App still shows an integer value.
Where do you see that? Can you post screenshots from an Eve and from a Shelly. |
To the If you want to discuss more about that power state thing, open a new issue, discussing it here mixed with the float thing is a irritating. A update to the power values will follow. |
thanks for your investigations! the Shurtcut/Automation part within Homekit App was crashing countless times, not wondering there are more bugs. Update of power values in HK means you will follow up with some findings? |
little pre information: a HomeKit Characteristic like the current power consumption, has 3 range values, a min value, a max value and a step value. I found the mistake I made ~2 years ago, as I have made the initial implementation of the power stuff. I have tried to implement it as float then, but I made a mistake and set the step value to 1.0, that's resulted in homekit rounds the values up to an integer. I have fixed that now. Here is the PR for that feature: #1197 |
prerelease build are now linked in the pr #1197 |
@timoschilling |
@rs38 I still on it, there is a problem and I'm not sure what it is. The sensor itself can 3 decimal digits. I will update the PR if there is something new. |
@timoschilling how can I help/assist? what are the units you are speaking of? let me think loud: But at least the Eve App is only showing kWh with 2 decimals, which would be a minimum of 10Wh and no further decimals. How would that fit into sth. which looks like 16bit Uint plus 1 decimal I found in the lastest changes? if you gather energy in Wh with 3 decimals, you will end up having kWh with 6 decimals. Are there any HK reads for a newbie like me? Or even better: a test suite to play with virtual sensors and learn from the behaviour in the Eve app and Homekit "layer"? |
I need time to recap every findings and retest some things. Will come back with an update then. |
Shelly plus 1PM:
I just did the switch to Homekit firmware and added it to Homekit, which was seamless and easy and works fine!!
However I noticed that the power (instant and sum) sensor data via Homekit changed in precision and some are lost (e.g. volts).
Native Shelly connection was providing 1 decimals for power and and now passed through to HK it's only integer.
Also energy sensor data is way less in precision.
Is this behaviour intentionally or a limitation of HK?
(Philips Hue bridge with Matter beta shows a very similar reduction in precision compared to native connection)
The text was updated successfully, but these errors were encountered: