Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiKeyRef #6

Open
cameronclaero opened this issue Jun 2, 2023 · 1 comment
Open

apiKeyRef #6

cameronclaero opened this issue Jun 2, 2023 · 1 comment

Comments

@cameronclaero
Copy link

Hi there, would it be possible to add apiKeyRef, so that a secret can be passed in ?

Thank you

@restebanez
Copy link

It'd be great to port the apiKeyRef implementation here.
The current way to pass the Linode token is in plain text :(

apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  name: webhook-linode-dns
  namespace: cert-manager
spec:
  acme:
    server: https://acme-v02.api.letsencrypt.org/directory
    email: [email protected]
    privateKeySecretRef:
      name: letsencrypt-linode-dns-key
    solvers:
    - dns01:
        webhook:
          solverName: linode
          groupName: acme.cluster.local
          config:
            apiKey: <linode-plain-text-token>

The previous way to pass it was:

apiVersion: cert-manager.io/v1
kind: ClusterIssuer
metadata:
  name: webhook-linode-dns
  namespace: cert-manager
spec:
  acme:
    server: https://acme-v02.api.letsencrypt.org/directory
    email: [email protected]
    privateKeySecretRef:
      name: letsencrypt-linode-dns-key
    solvers:
    - dns01:
        webhook:
          solverName: linode
          groupName: acme.cluster.local
          config:
            apiKeySecretRef: # This doesn't work anymore
               name: dns-scoped-linode-token
               key: token

I've noticed that if you use the apiKeySecretRef way it will fail silently with this message:

find record example.net. _acme-challenge.example.net.                                                                                                                                               
find domain example.net  

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants