collections breaks Array#find behavior

[erossignon]

Spotted here node-opcua/node-opcua#248

Collections v5.0.5 seems to break and replace some Array methods, introducing breaking changes.

How to reproduce:

var a = ["e1","e2","e3"];
console.log(" before   ", a.find(function(e) { return e=="e1";}));
var collections = require("collections/shim-array");
console.log(" after    ", a.find(function(e) { return e=="e1";}));

[codebling]

See also #162, #116, #95 and #94

[stevenvachon]

Seriously, this stupid module is breaking my code. Please unpublish.

[kriskowal]

For what it's worth, I'm sorry.

[kriskowal]

It's worth noting that this issue is fixed in version 2, but walked backward in version 3 and I think 4. It might be good for the collections community for the version of this library with the "latest" tag in npm is one that fixes this problem and that legacy applications should pin to the legacy versions.

[hthetiot]

Duplicate #185

[codebling]

See also issues #36 #70 #94 #95 #116 #139 #145 #162 #165 #169 #178 #182 #185 #197 #215 #220 and PRs #94 #95 #116 #173 #189 #212. Branch v2 fixes these issues by avoiding global object modification.