Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thin out the prelude and safeScope #222

Open
MostAwesomeDude opened this issue Dec 2, 2020 · 0 comments
Open

Thin out the prelude and safeScope #222

MostAwesomeDude opened this issue Dec 2, 2020 · 0 comments

Comments

@MostAwesomeDude
Copy link
Contributor

Let's slim down for the new year.

The following names can be removed entirely:

  • trace
  • _validateFor

The following names can be factored, with their modules moving to mast/lib/ and being imported where they're used:

  • makeBrandPair
  • makeLazySlot, with a small lexer change
  • normalize can be called something better; it transforms prelude-style ASTs to ASDL-style ASTs

This would probably not be worth any measurable speedup, but it removes code from an increasingly-undesired prelude.
MostAwesomeDude added a commit that referenced this issue Dec 3, 2020
@MostAwesomeDude
prelude: Move makeBrandPair to lib/sealing.
86bb1be 
New module, same API and unit tests and copyright notice. I did add a
couple docstrings though. Dependent modules were updated too.

Refs #222.
MostAwesomeDude added a commit that referenced this issue Dec 3, 2020
@MostAwesomeDude
Remove _validateFor.
a2049a8 
Refs #222.
MostAwesomeDude added a commit that referenced this issue Dec 3, 2020
@MostAwesomeDude
Remove trace.
a5dc519 
This has been an alias for traceln for a while.

Refs #222.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MostAwesomeDude