From 3cf6fee6332b9351381d5a92b046d2821b985708 Mon Sep 17 00:00:00 2001 From: "Eloy Lafuente (stronk7)" Date: Sat, 16 Mar 2024 12:03:28 +0100 Subject: [PATCH] Remove phpcpd (deprecated) from dist and explain docs Better stop having the deprecated phpcpd command available in the dist and explain docs, so newcomers won't enable it by default. It's going to be removed in v5. Part of #262, credit goes to @jrchamp --- .travis.dist.yml | 1 - docs/GHAFileExplained.md | 5 ----- docs/TravisFileExplained.md | 4 ---- gha.dist.yml | 5 ----- 4 files changed, 15 deletions(-) diff --git a/.travis.dist.yml b/.travis.dist.yml index 20ab597d..60abc893 100644 --- a/.travis.dist.yml +++ b/.travis.dist.yml @@ -51,7 +51,6 @@ install: script: - moodle-plugin-ci phplint - - moodle-plugin-ci phpcpd - moodle-plugin-ci phpmd - moodle-plugin-ci phpcs --max-warnings 0 - moodle-plugin-ci phpdoc --max-warnings 0 diff --git a/docs/GHAFileExplained.md b/docs/GHAFileExplained.md index aca304a5..128dfc96 100644 --- a/docs/GHAFileExplained.md +++ b/docs/GHAFileExplained.md @@ -142,11 +142,6 @@ jobs: if: ${{ !cancelled() }} # prevents CI run stopping if step failed. run: moodle-plugin-ci phplint - - name: PHP Copy/Paste Detector # DEPRECATED - continue-on-error: true # This step will show errors but will not fail - if: ${{ !cancelled() }} - run: moodle-plugin-ci phpcpd - - name: PHP Mess Detector continue-on-error: true if: ${{ !cancelled() }} diff --git a/docs/TravisFileExplained.md b/docs/TravisFileExplained.md index 708d2ca8..afbf4aa1 100644 --- a/docs/TravisFileExplained.md +++ b/docs/TravisFileExplained.md @@ -129,10 +129,6 @@ install: script: # This step lints your PHP files to check for syntax errors. - moodle-plugin-ci phplint -# This step runs the PHP Copy/Paste Detector on your plugin. -# This helps to find code duplication. -# (DEPRECATED) - - moodle-plugin-ci phpcpd # This step runs the PHP Mess Detector on your plugin. This helps to find # potential problems with your code which can result in # refactoring opportunities. diff --git a/gha.dist.yml b/gha.dist.yml index 960b2944..95d6d9b3 100644 --- a/gha.dist.yml +++ b/gha.dist.yml @@ -70,11 +70,6 @@ jobs: if: ${{ !cancelled() }} run: moodle-plugin-ci phplint - - name: PHP Copy/Paste Detector - continue-on-error: true # This step will show errors but will not fail - if: ${{ !cancelled() }} - run: moodle-plugin-ci phpcpd - - name: PHP Mess Detector continue-on-error: true # This step will show errors but will not fail if: ${{ !cancelled() }}