Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please Use Standard Flag Images #49

Open
jrchamp opened this issue Aug 5, 2015 · 2 comments
Open

Please Use Standard Flag Images #49

jrchamp opened this issue Aug 5, 2015 · 2 comments

Comments

@jrchamp
Copy link

jrchamp commented Aug 5, 2015

The flag "on" image features the pirate flag, which was identified by our Sociology professors as a possible trauma trigger. I imagine that it was intended to be playful, but it's not necessary and uses non-standard flag indicators.

@jason-platts
Copy link
Member

I think it actually looks more like the ISIS flag, so that is even more traumatic!

Anyway, on a more serious note the reason that there is a separate flag specifically for the plugin is that we use one here that it is different to the main moodle flag.

Not sure why the pirate style flag is included, we don't use that here - we override at theme level.

Which is what I would suggest you do (theme/yourtheme/pix_plugins/mod/forumng/flag.on.png) or just replace the ones in the plugin dir with your icons of choice.

I will replace the flags with copies of the core ones at some point in the near future (so will leave this issue open till then so I don't forget).

@sammarshallou
Copy link
Member

It is a pirate flag and ISIS weren't around when I made that icon! (Not sure why it didn't use the Moodle standard flag icon, maybe there wasn't a suitable one at that point in 1.x.)

I suppose Moodle might be used near Somalia or for, I don't know, providing training for ship captains or something, so maybe that would be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants