Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on tool_datamasking missing #128

Open
sharpchi opened this issue Sep 21, 2022 · 1 comment
Open

Dependency on tool_datamasking missing #128

sharpchi opened this issue Sep 21, 2022 · 1 comment

Comments

@sharpchi
Copy link

sharpchi commented Sep 21, 2022

It appears oublog has a dependency on tool_datamasking:

  • mod/oublog/classes/tool_datamasking.php
  • mod/oublog/tests/tool_datamasking_test.php (test fails)

I can't find tool_datamasking in the Moodle repo or github, so assume it's a private repo.

Moodle 4.0.3, PHP 8.0, MOODLE_311_STABLE branch of this plugin

@sammarshallou
Copy link
Member

There isn't a dependency in the actual code (tool_datamasking.php will not be used unless tool_datamasking is installed) but you're right, the unit test is incorrect. That unit test should be skipped if tool_datamasking is not installed.

And yes tool_datamasking hasn't been made publicly available yet (no particular reason not to but it might need tidying up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants