Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other party members notes do not update without refresh #179

Open
ufkhan97 opened this issue Apr 11, 2022 · 4 comments
Open

Other party members notes do not update without refresh #179

ufkhan97 opened this issue Apr 11, 2022 · 4 comments

Comments

@ufkhan97
Copy link

@blahkheart and I found this bug today:

Describe the bug
When a user edits their note, other users do not see the updated note unless they refresh their screen.

To Reproduce

  1. Create a party and invite someone to it
  2. Update your note
  3. Ask if your note updated for the other person
  4. Refresh the screen and see if the note updated now

Expected behavior
Expected notes to update for each other in realtime

Screenshots
Please see below

Desktop (please complete the following information):

  • OS: macOS Monterey 12.0.1
  • Browser: Chrome
  • Version: 100.0

Additional context
Add any other context about the problem here.

@blahkheart
Copy link
Contributor

Find a screen recording of the issue below

notes.dont.change.till.refresh.mp4

@Nazeeh21
Copy link
Member

Nazeeh21 commented Apr 21, 2022

According to our current mechanism, we are currently storing notes data in our database. Because we are not using WebSockets, the frontend will not update unless we fetch the data again and then display the updated data to other users. One possible solution is to keep querying the backend at a fixed interval of time so that the user has updated data (this doesn't seem like a good solution to me because it will keep querying the backend even if the data hasn't changed and will eventually slow down the performance due to more data fetching). LMKYT on this.

@hmrtn
Copy link
Member

hmrtn commented Apr 26, 2022

I think querying the backend a couple of times a minute would be the simplest solution for now.

@blahkheart
Copy link
Contributor

Created a pr closing #191

hmrtn added a commit that referenced this issue Apr 29, 2022
Other party members notes do not update without refresh: issue #179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants