Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mergedContext references incorrect index when waiting on a context pair to complete #27

Open
BarakatX2 opened this issue Sep 23, 2022 · 0 comments

Comments

@BarakatX2
Copy link

select {
case <-ctxs.ctxs[0].Done():
ctxs.err = ctxs.ctxs[0].Err()
case <-ctxs.ctxs[1].Done():
ctxs.err = ctxs.ctxs[0].Err()
}

The second assignment incorrectly references the 0 index. This results in the context error being set to nil when it should never be set to nil. The next time the context is passed to another, it causes a panic that crashes the entire server:

panic: context: internal error: missing cancel error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant