diff --git a/README.md b/README.md index 7cc9c1cfb61..422079f6ff7 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ This repository contains source code and design documents for MOSIP ID Authentic Refer to [SQL scripts](db_scripts). ## Build & run (for developers) -The project requires JDK 1.11. +The project requires JDK 1.21. 1. Build and install: ``` $ cd kernel diff --git a/authentication/authentication-common/src/main/java/io/mosip/authentication/common/service/integration/DataShareManager.java b/authentication/authentication-common/src/main/java/io/mosip/authentication/common/service/integration/DataShareManager.java index 65a648493d4..8192a2d8639 100644 --- a/authentication/authentication-common/src/main/java/io/mosip/authentication/common/service/integration/DataShareManager.java +++ b/authentication/authentication-common/src/main/java/io/mosip/authentication/common/service/integration/DataShareManager.java @@ -55,8 +55,11 @@ public R downloadObject(String dataShareUrl, Class clazz, boolean decrypt RestRequestDTO request = restRequestFactory.buildRequest(RestServicesConstants.DATA_SHARE_GET, null, String.class); request.setUri(dataShareUrl); String responseStr = restTemplate.getForObject(dataShareUrl, String.class); + if (responseStr == null) { + throw new IdAuthUncheckedException(IdAuthenticationErrorConstants.UNABLE_TO_PROCESS.getErrorCode(), IdAuthenticationErrorConstants.UNABLE_TO_PROCESS.getErrorMessage()); + } Optional> errorOpt = RestUtil.getError(responseStr, mapper); - + if (errorOpt.isEmpty()) { R result; if (decryptionRequired) { diff --git a/authentication/authentication-common/src/main/java/io/mosip/authentication/common/service/websub/impl/IdChangeEventsInitializer.java b/authentication/authentication-common/src/main/java/io/mosip/authentication/common/service/websub/impl/IdChangeEventsInitializer.java index f1f29fa3ac5..2fa3bd6245a 100644 --- a/authentication/authentication-common/src/main/java/io/mosip/authentication/common/service/websub/impl/IdChangeEventsInitializer.java +++ b/authentication/authentication-common/src/main/java/io/mosip/authentication/common/service/websub/impl/IdChangeEventsInitializer.java @@ -89,7 +89,6 @@ private void subscribeForCredentialIssueanceEvents(String topicPrefix) { webSubHelper.subscribe(subscriptionRequest); logger.info(IdAuthCommonConstants.SESSION_ID, "subscribeForCredentialIssueanceEvents", "", "Subscribed to topic: " + topic); } catch (Exception e) { - e.printStackTrace(); logger.info(IdAuthCommonConstants.SESSION_ID, "subscribeForCredentialIssueanceEvents", e.getClass().toString(), "Error subscribing topic: "+ topic +"\n" + e.getMessage()); throw e; }