From 90caa754b3aed928e9276cc69974fda707007a47 Mon Sep 17 00:00:00 2001
From: Mahesh-Binayak <76687012+Mahesh-Binayak@users.noreply.github.com>
Date: Thu, 25 Jul 2024 16:36:50 +0530
Subject: [PATCH] [DSD-5599]added changes for sonar coverage. (#279)

* [DSD-5599]added changes for sonar coverage.

Signed-off-by: Mahesh.Binayak <Mahesh.Binayak@technoforte.co.in>

* [DSD-5599]added changes for sonar coverage and dco check

Signed-off-by: Mahesh.Binayak <Mahesh.Binayak@technoforte.co.in>

---------

Signed-off-by: Mahesh.Binayak <Mahesh.Binayak@technoforte.co.in>
---
 README.md                  |  2 +-
 kafka-admin-client/pom.xml | 17 ++++-------------
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/README.md b/README.md
index 27df6ca..8a44b98 100644
--- a/README.md
+++ b/README.md
@@ -37,7 +37,7 @@ To integrate any kafka(either local or remote) with hub following properties nee
  - KAFKA_BOOTSTRAP_NODE
 
 ### Starting the IDP
-After starting IDP and Auth service following properties need to updated in both websub service.
+After starting IDP and Auth service following properties need to be updated in both websub service.
 
  - MOSIP_AUTH_BASE_URL
  - MOSIP_AUTH_VALIDATE_TOKEN_URL
diff --git a/kafka-admin-client/pom.xml b/kafka-admin-client/pom.xml
index d74dc35..bcd8095 100644
--- a/kafka-admin-client/pom.xml
+++ b/kafka-admin-client/pom.xml
@@ -110,13 +110,10 @@
 				<artifactId>maven-surefire-plugin</artifactId>
 				<version>${maven.surefire.plugin.version}</version>
 				<configuration>
-					<skipTests>false</skipTests>
+					<skipTests>${skipTests}</skipTests>
 					<skip>false</skip>
 					<argLine>
-						--add-opens java.base/java.lang=ALL-UNNAMED
-						--add-opens java.base/java.util=ALL-UNNAMED
-						--illegal-access=debug
-						--enable-preview
+						${argLine} --add-opens java.xml/jdk.xml.internal=ALL-UNNAMED --add-opens java.base/java.lang=ALL-UNNAMED --add-opens java.base/java.util=ALL-UNNAMED --illegal-access=permit
 					</argLine>
 				</configuration>
 			</plugin>
@@ -134,14 +131,8 @@
 						<id>report</id>
 						<phase>prepare-package</phase>
 						<goals>
-							<goal>report-aggregate</goal>
+							<goal>report</goal>
 						</goals>
-						<configuration>
-						    <outputDirectory>${project.build.directory}/site/jacoco-aggregate</outputDirectory>
-                                                    <reportFormats>
-                                                        <reportFormat>XML</reportFormat>
-                                                    </reportFormats>
-					        </configuration>
 					</execution>
 				</executions>
 			</plugin>
@@ -254,7 +245,7 @@
 			<properties>
 				<sonar.sources>.</sonar.sources>
 				<sonar.inclusions>src/main/java/**,src/main/resources/**</sonar.inclusions>
-				<sonar.coverage.jacoco.xmlReportPaths>${project.build.directory}/site/jacoco-aggregate/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
+				<sonar.exclusions>${sonar.coverage.exclusions}</sonar.exclusions>
 				<sonar.host.url>https://sonarcloud.io</sonar.host.url>
 			</properties>
 			<activation>