Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

36Go log file #123

Open
laem opened this issue Aug 5, 2024 · 4 comments
Open

36Go log file #123

laem opened this issue Aug 5, 2024 · 4 comments

Comments

@laem
Copy link

laem commented Aug 5, 2024

My motis/data/log/nigiri.txt file is 36 Go. That's, huge, I wasn't expecting this and my server got out of disk space 😅 .

I wonder if I'm the only one getting this kind of log size ?

The file's last 10 000 lines are all similar :

2024-08-05T20:02:00Z | [error][loader.gtfs.services ] date 2025-12-25 00:00 for service 94504|238309|0 out of range [tt_interval=[2024-07-31 00:00, 2024-08-08 00:00[, calendar=[2024-11-01 00:00, 2024-11-02 00:00[, iterating=[2024-11-01 00:00, 2024-08-08 00:00[]

@felixguendling
Copy link
Member

Yes, we also have that. I guess the best option would be to remove the log statement. It has been useful to debug issues with datasets where services have all days set to 1 in calendar.txt and no exceptions but it doesn't appear on the map or in the routing. Then often the reason was that the GTFS interval didn't overlap the selected timetable interval.

@felixguendling
Copy link
Member

You can open a PR removing those lines:

log(log_lvl::error, "loader.gtfs.services",
"date {} for service {} out of range [tt_interval={}, calendar={}, "
"iterating={}]",
fmt::streamed(d), service_name, tt_interval, c.interval_,
interval{from, to});

@laem
Copy link
Author

laem commented Aug 6, 2024

Thanks ! Could they be placed under the condition of a debug mode in the options ?

@felixguendling
Copy link
Member

For now it's enough to just remove those lines.

Overall I think it would make sense to have some kind of structured (e.g. JSON) log that contains all problems found/fixed/ignored (such as dangling references, trips with less than 2 stops, etc.) + a UI that displays this information in a way so you can filter issues by type, dataset, etc. I know there are already feed validation tools (at least for GTFS, not sure what's the state for NeTEx) for this kind of job. However, I'm not sure if they can scale to the number/size of feeds MOTIS can load with reasonable processing time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants