From 600d25c0d0a2881fd22d191f9f3cd1a9c525897f Mon Sep 17 00:00:00 2001
From: Pablo Hoch <pablo@melaxis.com>
Date: Mon, 10 Jul 2023 17:16:57 +0200
Subject: [PATCH] handle sidewalk:{both,left,right} tags

---
 src/preprocessing/osm/way_info.cc | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/src/preprocessing/osm/way_info.cc b/src/preprocessing/osm/way_info.cc
index c0845ba..ce0597d 100644
--- a/src/preprocessing/osm/way_info.cc
+++ b/src/preprocessing/osm/way_info.cc
@@ -1,4 +1,5 @@
 #include <cstring>
+#include <string_view>
 
 #include "ppr/preprocessing/clamp.h"
 #include "ppr/preprocessing/names.h"
@@ -14,6 +15,8 @@
 #include "ppr/preprocessing/osm/wheelchair.h"
 #include "ppr/preprocessing/osm/width.h"
 
+using namespace std::literals;
+
 namespace ppr::preprocessing::osm {
 
 bool is_street_with_sidewalks(street_type const street) {
@@ -134,6 +137,14 @@ way_info get_platform_info(osmium::Way const& way, osmium::TagList const& tags,
   return {info_idx, false, false, width, layer};
 }
 
+bool should_generate_sidewalk(char const* value, bool const def) {
+  if (value == nullptr) {
+    return def;
+  }
+  // possible values: yes, no, separate
+  return value == "yes"sv;
+}
+
 way_info get_highway_info(osmium::Way const& way, osmium::TagList const& tags,
                           osm_graph& graph) {
   auto const* highway = tags["highway"];
@@ -153,6 +164,7 @@ way_info get_highway_info(osmium::Way const& way, osmium::TagList const& tags,
     type = edge_type::CROSSING;
   } else if (is_street_with_sidewalks(street)) {
     type = edge_type::STREET;
+
     auto const* sidewalk = tags["sidewalk"];
     if (sidewalk != nullptr) {
       if (strcmp(sidewalk, "left") == 0) {
@@ -169,6 +181,16 @@ way_info get_highway_info(osmium::Way const& way, osmium::TagList const& tags,
       sidewalk_left = true;
       sidewalk_right = true;
     }
+
+    auto const* sidewalk_both = tags["sidewalk:both"];
+    sidewalk_left = should_generate_sidewalk(sidewalk_both, sidewalk_left);
+    sidewalk_right = should_generate_sidewalk(sidewalk_both, sidewalk_right);
+
+    sidewalk_left =
+        should_generate_sidewalk(tags["sidewalk:left"], sidewalk_left);
+    sidewalk_right =
+        should_generate_sidewalk(tags["sidewalk:right"], sidewalk_right);
+
     if ((street == street_type::LIVING || street == street_type::RESIDENTIAL ||
          street == street_type::SERVICE ||
          street == street_type::UNCLASSIFIED) &&