Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab Tray diffable data source apply snapshot causes hangs #24321

Open
data-sync-user opened this issue Jan 24, 2025 · 0 comments
Open

Tab Tray diffable data source apply snapshot causes hangs #24321

data-sync-user opened this issue Jan 24, 2025 · 0 comments

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jan 24, 2025

The TabDisplayDiffableDataSource regenerates a UUID each time apply snap shot is called forcing the snapshot to always be different. This causes a data reload even when it is not necessary. This was put in place as the best strategy at the time to force the section header for inactive tabs to reload without crashing on iOS 15.

This was causing hangs because newState on the TabTray is called often (by design), but reloading the table each time is a performance issue. An initial fix was put in to just prevent the reload from happening but does not fix the underlying problem. We can instead use information on the tabState to force this reload instead of doing it every time with the UUID.

┆Issue is synchronized with this Jira Bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant