Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve From<ErrorKind> for Error #932

Closed
pjenvey opened this issue Nov 21, 2020 · 1 comment
Closed

Improve From<ErrorKind> for Error #932

pjenvey opened this issue Nov 21, 2020 · 1 comment
Labels
cleanup enhancement New feature or request

Comments

@pjenvey
Copy link
Member

pjenvey commented Nov 21, 2020

Mark's reflexive From for Error types in autoendpoint may make it easier to convert from lower level errors (like DbErrorKind) directly into higher level ApiErrors.

We may want to make failure_boilerplate! implement it for all types or only emit it for the higher level ApiError -- we can look at what autoendpoint does here as an example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup enhancement New feature or request
Projects
Services Engineering
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjenvey @ethowitz