Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Investigate why 2735779 was not added to the review queue #15311

Open
1 task
dotproto opened this issue Jan 28, 2025 · 1 comment
Open
1 task

[Task]: Investigate why 2735779 was not added to the review queue #15311

dotproto opened this issue Jan 28, 2025 · 1 comment
Labels
needs:info repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server

Comments

@dotproto
Copy link

dotproto commented Jan 28, 2025

Description

A developer reached out to request assistance unblocking review of their add-on (internal ID 2735779). It turned out that the developer was awaiting a reply from a reviewer but the developer's response did not cause the submission to re-enter the review queue. @wagnerand noted that he was not able to "set NHR on version 1.0.5. No error, it just isn’t set."

Related to https://mozilla-hub.atlassian.net/browse/ADDREV-266

NOTE: I cannot remove the labels on this issue.

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

@dotproto dotproto added needs:info repository:addons-server Issue relating to addons-server repository:addons-frontend Issue relating to addons-frontend labels Jan 28, 2025
@diox
Copy link
Member

diox commented Jan 28, 2025

The version was in the queue.

Timeline:

  • Jan 9th, the developer replied on version 1.0.5, causing the add-on to be added to the queue
  • Jan 15th, a reviewer confirmed auto-approval of version 1.0.2. This is a silent action that doesn't notify the developer, but as all reviewer actions on the listed channel, we consider that the reviewer looked at all versions needing review, and we flipped all needs human review flags on all versions in the listed channel to inactive.

I don't know what the problem that Andreas had regarding manually setting NHR on that version, but it's a different problem (likely an hidden validation error).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:info repository:addons-frontend Issue relating to addons-frontend repository:addons-server Issue relating to addons-server
Projects
None yet
Development

No branches or pull requests

2 participants