Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: promoted add-ons and resolving them with override decisions - override approve with disable #15328

Open
1 task done
ioanarusiczki opened this issue Feb 3, 2025 · 1 comment

Comments

@ioanarusiczki
Copy link

ioanarusiczki commented Feb 3, 2025

What happened?

While making some regression testing (after #15306)

The 2nd level approval + override scenarios

Case is: override approve with disable

  1. A report for a promoted add-on goes to Cinder and decision is Approve (an email goes to the reporter as expected, with an appeal url attached) ✅
  2. It's overridden with a policy that would disable: this action is held for a decision in 2nd level approval queue from rev tools ✅
    https://reviewers.addons-dev.allizom.org/en-US/reviewers/decision-review/6627
  3. Observe there are 2 options available: proceed and approve (without forward to rev tools, the third option is usually present with abuse reports) ❓
  4. Decision in rev tools is: approve

What did you expect to happen?

A new email is sent to reporter but I think it's not correct (it should say to reporter that the final decision is that content stays up without an appeal url attached)

Image

Instead of approve , choosing proceed at step 4 -> looks good

Is there an existing issue for this?

  • I have searched the existing issues

┆Issue is synchronized with this Jira Task

@ioanarusiczki
Copy link
Author

Similar issues

#15329
#15330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant