Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Enable fake FXA in local production images #15331

Open
1 task
KevinMind opened this issue Feb 3, 2025 · 0 comments · May be fixed by mozilla/addons-server#23049
Open
1 task

[Task]: Enable fake FXA in local production images #15331

KevinMind opened this issue Feb 3, 2025 · 0 comments · May be fixed by mozilla/addons-server#23049
Assignees
Labels
needs:info repository:addons-server Issue relating to addons-server

Comments

@KevinMind
Copy link
Contributor

KevinMind commented Feb 3, 2025

Description

Previously the use_fake_fxa() function returned true only if settings.DEV_MODE and settings.USE_FAKE_FXA were both true.
This was meant to ensure we do NOT use fake fxa in production and to make it the default in development.

This was clunky though. There are really not many use cases for setting up fxa locally but even when running production images locally, we were then defaulting to an fxa redirect.. That's annoying.

We can set it up smarter to rely on the presence of a valid fxa client_id.. the default is .. If the value is . then we use the fake client, otherwise the real one.

This enables virtually the same behavior with a lot better defaults.

Acceptance Criteria

Milestones/checkpoints

Preview Give feedback

Checks

  • If I have identified that the work is specific to a repository, I have removed "repository:addons-server" or "repository:addons-frontend"

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:info repository:addons-server Issue relating to addons-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant