Extension Workshop URLS must end with a trailing slash to not lose query params

[muffinresearch]

Related to mozilla/extension-workshop#935 and #8234

Query params are being lost in the redirection to add a slash. Since there doesn't appear to be a way to fix the redirection on s3, for now our best mitigation will be to ensure all extension workshop URLS have a trailing slash to avoid the redirection.

To fix this we'll need to search for extension workshop urls and update accordingly.

Here's a repo search, but a code search locally should also be checked.

[eviljeff]

From a local search, it's looks like it's just the devhub links from #8234 that were added without the trailing slash:

olympia • src\olympia\devhub\templates\devhub\nav.html:
  36        <ul>
  37:         <li><a href="https://extensionworkshop.com/documentation/develop?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=dev-hub-legacy-menu-link">
  38            {{ _('Extension Development') }}</a></li>
  39:         <li><a href="https://extensionworkshop.com/documentation/themes?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=dev-hub-legacy-menu-link">
  40            {{ _('Themes') }}</a></li>
  41:         <li><a href="https://extensionworkshop.com/documentation/publish/add-on-policies?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=dev-hub-legacy-menu-link">
  42            {{ _('Developer Policies') }}</a></li>

We also have an EXTENSION_WORKSHOP_URL setting (I just checked and all the use with that setting ends in a / already) - it'd be more consistent if those links above were changed to use the setting, imo.

[eviljeff]

Also logged #8254 for the urls without UTM params currently

[championshuttler]

@siddhi523 looks interesting?

[siddhi523]

I will try this thanks @championshuttler

[caitmuenster]

To fix this issue, a / needs to be added before the ? mark in the URL.

If this is your first contribution, please refer to https://wiki.mozilla.org/Add-ons/Contribute/Code on how to get started.

Mentor: @willdurand

@siddhi523, would you be interested in fixing this? :)

[siddhi523]

Thanks @caitmuenster I got engaged with some other issues, On it!!

[AlexandraMoga]

UTM parameters are now preserved when navigating to Extension Workshop from the Documentation menu in the legacy DevHub:

This issue is verified fixed on -dev.