From e54dfae00c669cdce48eecb25dee53fe328db81f Mon Sep 17 00:00:00 2001 From: Lars Eggert Date: Sat, 23 Mar 2024 17:22:10 +1000 Subject: [PATCH 1/2] ci: Disable some caching The docker and python caches put quite a bit of stress on the GHA cache, causing it - for example - to time out the benchmark results too soon. See https://github.com/mozilla/neqo/actions/caches --- .github/actions/quic-interop-runner/action.yml | 5 +++-- .github/workflows/qns.yml | 8 +++++++- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.github/actions/quic-interop-runner/action.yml b/.github/actions/quic-interop-runner/action.yml index ef4865bde6..2fe87a8f9d 100644 --- a/.github/actions/quic-interop-runner/action.yml +++ b/.github/actions/quic-interop-runner/action.yml @@ -52,8 +52,9 @@ runs: - uses: actions/setup-python@v5 with: python-version: 3.8 - cache: 'pip' - cache-dependency-path: 'quic-interop-runner/requirements.txt' + # This puts too much stress on our cache, causing other things to be flushed too early: + # cache: 'pip' + # cache-dependency-path: 'quic-interop-runner/requirements.txt' - name: Install Python packages run: | diff --git a/.github/workflows/qns.yml b/.github/workflows/qns.yml index caadb022df..cfbcd8fa07 100644 --- a/.github/workflows/qns.yml +++ b/.github/workflows/qns.yml @@ -23,6 +23,10 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 + with: + # Leaving `cache-binary` at `true` puts too much stress on our cache, + # causing other things to be flushed too early. + cache-binary: false - name: Login to GitHub Container Registry uses: docker/login-action@v3 @@ -55,7 +59,9 @@ jobs: build-args: | RUST_VERSION=stable cache-from: type=gha - cache-to: type=gha,mode=max + # Setting `mode` to `max` puts too much stress on our cache, + # causing other things to be flushed too early. + cache-to: type=gha,mode=min # On pull requests only build amd64 for the sake of CI time. platforms: ${{ github.event_name == 'pull_request' && 'linux/amd64' || 'linux/amd64, linux/arm64' }} load: ${{ github.event_name == 'pull_request' }} From e9e5a87e6210fc76d6067985bd89f6d5c95cfbba Mon Sep 17 00:00:00 2001 From: Lars Eggert Date: Sat, 23 Mar 2024 17:32:19 +1000 Subject: [PATCH 2/2] No `cache-binary`?! --- .github/workflows/qns.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/qns.yml b/.github/workflows/qns.yml index cfbcd8fa07..68455c1a2e 100644 --- a/.github/workflows/qns.yml +++ b/.github/workflows/qns.yml @@ -23,10 +23,6 @@ jobs: - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3 - with: - # Leaving `cache-binary` at `true` puts too much stress on our cache, - # causing other things to be flushed too early. - cache-binary: false - name: Login to GitHub Container Registry uses: docker/login-action@v3