New created tags are not saved from the new query page

[madalincm]

Steps to reproduce:

1. Open the new query page: https://data-stmo-rc.stage.mozaws.net/queries/new
2. Click on the Add tag button
3. Enter a new tag name and click ok to add it to the query
4. Go to the queries page and search for the created tag

Expected results:

The new tag is saved and it is displayed in the right side of the queries page. It can be used in other queries

Actual results:

The tag is not displayed in the queries page and it can't be used.

Notes

Verified in FF66 win7x64 Issue can be reproduced in STMO-RC
Please view this screencast:

[emtwo]

@madalincm In your screencast, I cannot tell if you saved the query that you added a tag to? It seems that tags will not be saved if the query itself is not saved (I think that makes sense).

I couldn't reproduce the issue myself if I made sure to save the query. Please let me know, thanks!

[madalincm]

I have not saved the query. The issue can be only reproduced in the new query page (once you save a query you are automatically redirected from the new query page).

Consider another scenario where this issue can be observed:

1. Go to the new query page
2. Create a new tag and add it to the query
3. Save the query
   --- at this moment the tag is not saved (you can't use it on other queries) and it is not added to the current query.

Here is my reasoning why this is an issue::

1. Visually you are informed that your tag was created (it is displayed next to the query title) But it was not created. You can't find it when searching for it from another query page.
2. If you save the query you expect that all the changes you made to that query until that point are saved. But that is not true for the tag you have created and added to the query.
3. The user is not clearly informed that he is not able to add a tag unless he saves first. He sees the tag next to the query title but after saving the tag disappears

[emtwo]

@madalincm ah yes! This does look like a bug. I would expect if you add a tag and save the query afterwards, the tag would remain.

I've confirmed that this bug currently exists in production stmo and in upstream.

I'm not sure we need to block release on it as it's not a regression, but we should perhaps fix it in the next release.

[jezdez]

This definitely should be filed upstream.