Tell the bindings about traits implemented by objects. #2196
Comments
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Aug 6, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance or whatever makes sense for them if they choose.
No bindings use it yet, fixes mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Aug 6, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance or whatever makes sense for them if they choose.
No bindings use it yet, fixes mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Aug 6, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance or whatever makes sense for them if they choose.
No bindings use it yet, fixes mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Aug 6, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance or whatever makes sense for them if they choose.
No bindings use it yet, fixes mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Sep 4, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance
Includes Python, Kotlin and Swift generating these sub-classes.
There's some undesirable re-wrapping when traits from these
objects gets passed back and forward, but seems to work surprisingly well.
Fixes mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Sep 4, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance
Includes Python, Kotlin and Swift generating these sub-classes.
There's some undesirable re-wrapping when traits from these
objects gets passed back and forward, but seems to work surprisingly well.
Fixes mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Sep 4, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance
Includes Python, Kotlin and Swift generating these sub-classes.
There's some undesirable re-wrapping when traits from these
objects gets passed back and forward, but seems to work surprisingly well.
Fixes mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Sep 4, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance
Includes Python, Kotlin and Swift generating these sub-classes.
There's some undesirable re-wrapping when traits from these
objects gets passed back and forward, but seems to work surprisingly well.
Fixes mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Sep 4, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Currently works by ignoring `MyTrait`. This adds new metadata
to record it, allowing foreign bindings to implement things like
inheritance
Includes Python, Kotlin and Swift generating these sub-classes.
There's some undesirable re-wrapping when traits from these
objects gets passed back and forward, but seems to work surprisingly well.
Fixes mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Oct 4, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Previously worked as it ignored `MyTrait`. This adds new metadata to record it,
allowing foreign bindings to implement things like inheritance.
Includes Python generating an inheritance chain to reflect this relationship.
This will not generate correct code if a struct declares more than 1 trait,
and there's some undesirable re-wrapping when traits from these objects gets
passed back and forward, but seems to work surprisingly well.
On the path to mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Oct 4, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Previously worked as it ignored `MyTrait`. This adds new metadata to record it,
allowing foreign bindings to implement things like inheritance.
Includes Python generating an inheritance chain to reflect this relationship.
This will not generate correct code if a struct declares more than 1 trait,
and there's some undesirable re-wrapping when traits from these objects gets
passed back and forward, but seems to work surprisingly well.
On the path to mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Oct 4, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Previously worked as it ignored `MyTrait`. This adds new metadata to record it,
allowing foreign bindings to implement things like inheritance.
Includes Python generating an inheritance chain to reflect this relationship.
This will not generate correct code if a struct declares more than 1 trait,
and there's some undesirable re-wrapping when traits from these objects gets
passed back and forward, but seems to work surprisingly well.
On the path to mozilla#2196.
mhammond
added a commit
to mhammond/uniffi-rs
that referenced
this issue
Oct 6, 2024
```
#[uniffi::export]
impl MyTrait for MyObject { ... }
```
Previously worked as it ignored `MyTrait`. This adds new metadata to record it,
allowing foreign bindings to implement things like inheritance.
Includes Python generating an inheritance chain to reflect this relationship.
This will not generate correct code if a struct declares more than 1 trait,
and there's some undesirable re-wrapping when traits from these objects gets
passed back and forward, but seems to work surprisingly well.
Fixes mozilla#2196.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #2169 there's:
and we should support it! It could mean
Generating the metadata for this is actually quite easy and sane (I've a wip ;), and we could land this without bindings support, which would be the hard part to do "correctly" - but that could come later and it's not strictly necessary for all bindings to support it.
wdyt?
The text was updated successfully, but these errors were encountered: