This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Refactored Developer Options code #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortimerGoro
suggested changes
Oct 9, 2018
|
Thanks @MortimerGoro! Default MSAA should be ok now |
bluemarvin
approved these changes
Oct 9, 2018
cvan
reviewed
Oct 10, 2018
app/src/main/res/values/strings.xml
Outdated
| @@ -35,7 +35,7 @@ | |||
| <string name="developer_options_events">Input Events</string> | |||
| <string name="developer_options_display_density">Display Density:</string> | |||
| <string name="developer_options_window_size">Window Size:</string> | |||
| <string name="developer_options_window_size_by">by</string> | |||
| <string name="developer_options_by">By</string> | |||
There was a problem hiding this comment.
the L10n string should be like Window Size: {width} × {height} or Window Size: {width} by {height}
we can't use the word By by itself, because the ordering of words doesn't make sense in all other languages
cvan
reviewed
Oct 10, 2018
app/src/main/res/values/strings.xml
Outdated
| <string name="developer_options_env_cave">Cave</string> | ||
| <string name="developer_options_env_void">Void</string> | ||
| <string name="developer_options_environments">Environment</string> | ||
| <string name="developer_options_env_meadow">meadow</string> |
There was a problem hiding this comment.
why ar these lowercased but the Pointer Color selections, for example, are not?
|
@cvan Fixed those two, thanks! |
keianhzo
force-pushed
the
developer-options-refactor
branch
from
343e82f to
633f59b
Compare
MortimerGoro
approved these changes
Oct 10, 2018
|
Looks like this is ready to land. Any outstanding issues can be addressed in a follow up issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #580 Refactored developer options code. Haven't replaced the scrollview for a listview as we don''t have so many elements as to affect the performance and would require some more work.