Skip to content
This repository was archived by the owner on Jul 22, 2024. It is now read-only.

clean up various L10n strings #711

Merged
merged 4 commits into from
Nov 8, 2018
Merged

clean up various L10n strings #711

merged 4 commits into from
Nov 8, 2018

Conversation

cvan
Copy link
Contributor

@cvan cvan commented Nov 2, 2018

Fixes #648

  • always use curly quotation marks when appropriate
  • merge voice_search_example into voice_search_start
  • add strings for Bookmarks
  • add strings for Tabs
  • add strings for Downloads
  • add strings for History
  • add strings for Settings changes
  • add strings for Keyboard changes
  • add strings for tooltips (see designs, from Add Tooltips across the UI #365 (comment))
  • review any missing strings from old Design Review decks
  • verify descriptions and STRs of L10n comments

@Delphine

@cvan cvan force-pushed the l10n-strings-cleanup branch from af01dff to 3765fdb Compare November 2, 2018 23:45
@keianhzo keianhzo force-pushed the l10n-strings-cleanup branch 2 times, most recently from 0018f46 to 1a13f3e Compare November 7, 2018 00:52
@keianhzo keianhzo force-pushed the l10n-strings-cleanup branch from 2f47c2a to df13a3e Compare November 7, 2018 22:48
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just given this a really cursory glance. This needs an actual review by someone who's not already having the next day.

Copy link

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave a first past at this. Same comments as Pike + some more.
Also, are we sure all the instances of %1$s should be replaced by domain name instead of app name? Some of these look strange to me (only called one out by looking again, others look like that too).
Probably just best to double check. Thanks!

Copy link

@Delphine Delphine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I think we're almost there.
Just wanted to make again extra sure all the instances of "'%1$s' will be replaced at runtime with the website's domain name." should in fact be "website domain name" and not "app". Sometimes it feels like we're more talking about the app, but then again, I don't know :)

@keianhzo keianhzo merged commit 5eeebbe into master Nov 8, 2018
@bluemarvin bluemarvin deleted the l10n-strings-cleanup branch November 13, 2018 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants