-
Notifications
You must be signed in to change notification settings - Fork 220
Conversation
af01dff
to
3765fdb
Compare
0018f46
to
1a13f3e
Compare
2f47c2a
to
df13a3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just given this a really cursory glance. This needs an actual review by someone who's not already having the next day.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave a first past at this. Same comments as Pike + some more.
Also, are we sure all the instances of %1$s should be replaced by domain name instead of app name? Some of these look strange to me (only called one out by looking again, others look like that too).
Probably just best to double check. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I think we're almost there.
Just wanted to make again extra sure all the instances of "'%1$s' will be replaced at runtime with the website's domain name." should in fact be "website domain name" and not "app". Sometimes it feels like we're more talking about the app, but then again, I don't know :)
Fixes #648
mergevoice_search_example
intovoice_search_start
add strings for Downloadsadd strings for Historyadd strings for Keyboard changes@Delphine