This repository was archived by the owner on Jul 22, 2024. It is now read-only.
Suggestions bar implementation #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When I click on the suggestions, nothing happens. This was on Oculus Go. |
|
@bluemarvin should be ok now. |
|
Great work! The suggestions bar is super usefull! I'm merging this, @bluemarvin you can add a follow up if you find anything else. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggestions bar implementation using browser-search, browser-domain and ui-autocompletion A-C modules. Provides domain and search engine based suggestions and domain auto-completion in the URL bar.