Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should SimConnect be in requirements.txt? #4

Open
jpwoodbu opened this issue Nov 10, 2020 · 1 comment
Open

Should SimConnect be in requirements.txt? #4

jpwoodbu opened this issue Nov 10, 2020 · 1 comment

Comments

@jpwoodbu
Copy link

The instructions don't mention running pip install simconnect so I did not. But after otherwise following the instructions (I think) and running msfs_landing_inspector.py , I got an import error from SimConnectCust/RequestList.py line 1 when it tried to import objects from SimConnect.

I ran pip install simconnect and the error was resolved. Would it make sense to include SimConnect in requirements.txt as well as including installing it in the instructions (or pip install -r requirements.txt)?

This is the full error message:

Traceback (most recent call last):
 File "<redacted>\MSFS-Landing-Inspector-master\msfs_landing_inspector.py", line 2, in <module>
   from SimConnectCust import *
 File "<redacted>\MSFS-Landing-Inspector-master\SimConnectCust\__init__.py", line 2, in <module>
   from .RequestList import AircraftRequests, Request
 File "<redacted>\MSFS-Landing-Inspector-master\SimConnectCust\RequestList.py", line 1, in <module>
   from SimConnect import *
ModuleNotFoundError: No module named 'SimConnect'
@mracko
Copy link
Owner

mracko commented Nov 10, 2020

Thanks for pointing that out. It's a bug in the RequestList.py file. Technically, you shouldn't need to install SimConnect because the Landing Inspector is using a slightly modified version of the original SimConnect library. Nevertheless, installing SimConnect just like you did will fix the issue for now.

I'll fix the issue later this week hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants