Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending messages of 131069 bytes or more causes disconnects #105

Open
cwacekINV opened this issue Aug 31, 2016 · 1 comment
Open

Sending messages of 131069 bytes or more causes disconnects #105

cwacekINV opened this issue Aug 31, 2016 · 1 comment

Comments

@cwacekINV
Copy link
Contributor

cwacekINV commented Aug 31, 2016 •
edited
Loading

If you send a message of 131069 bytes or more (don't ask why), the websocket connection will forcibly disconnect.

To reproduce

Apply the attached patch.txt to HEAD, run the chat example, put "131069" in the input box and hit enter (the patch just changes the input box to send a random string of that length). It will work fine with 131068.

Debugging

This appears to have something to do with websocket compression, specifically Sec-WebSocket-Extensions: permessage-deflate;. If you revert #96 (specifically 4d5e88b), everything works fine.
@cwacekINV
Copy link
Contributor Author

Specifically, this occurs if you're running tornado==4.1. It's fine with tornado==4.4

cwacekINV pushed a commit to cwacekINV/sockjs-tornado that referenced this issue Aug 31, 2016
Workaround for mrjoes#105. Don't compress for tornado <4.1
9be6633
mrjoes added a commit that referenced this issue Nov 3, 2016
@mrjoes
Merge pull request #106 from cwacekINV/master
940b7fe 
Workaround for #105. Don't compress for tornado <4.1
@foosel foosel mentioned this issue Nov 24, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cwacekINV